Voxelands Forum

The official Voxelands discussion forum

You are not logged in.

#1 2018-05-07 03:59:58

Wuzzy
Translaterer
Registered: 2014-09-03
Posts: 134

Some odd keyboard key names

The following strings are used for key names, but have confusing names. I suggest to change them:

- “Next” → Page down
- “Prior” → Page up
- “Capital” → Caps Lock


Secondly, the calender date string is concatenated (e.g. “Spring” + “, ” + “Day %u of Year %u”). This is bad for translators because of word order problems. This should be ideally done with format strings only, no concatenation at all.

Last edited by Wuzzy (2018-05-07 04:00:39)

Offline

#2 2018-05-07 15:28:23

neoh4x0r
Member
Registered: 2016-08-26
Posts: 48

Re: Some odd keyboard key names

Wuzzy wrote:

The following strings are used for key names, but have confusing names. I suggest to change them:

- “Next” → Page down
- “Prior” → Page up
- “Capital” → Caps Lock

I assume (at least for capital) you are referring to keycode.cpp: https://gitlab.com/voxelands/voxelands/ … e.cpp#L250

which is just loosely associating KEY_CAPITAL with Capital (so it shouldn't impact anything to change it?)

KeyNamesLang[20] = gettext("Capital");
KeyNamesLang[33] = gettext("Prior");
KeyNamesLang[34] = gettext("Next");
KeyNamesLang[20] = gettext("Caps Lock");
KeyNamesLang[33] = gettext("Page Up");
KeyNamesLang[34] = gettext("Page Down");

Offline

Board footer

Powered by FluxBB